jdoerfert added a comment. Can you make the test check for the diagnose message? Also, do we have a test to verify an isa trait is properly handled?
================ Comment at: clang/lib/Parse/ParseOpenMP.cpp:2533 + std::function<void(StringRef)> DiagUnknownTrait = [this, Loc]( + StringRef ISATrait) {}; + TargetOMPContext OMPCtx(ASTContext, std::move(DiagUnknownTrait), ---------------- Why doesn't this diagnose nothing? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116549/new/ https://reviews.llvm.org/D116549 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits