owenpan added a comment. In D116318#3211258 <https://reviews.llvm.org/D116318#3211258>, @curdeius wrote:
> Wasn't assert enough? Could you add a test with code that provokes the > problem? This fix is an NFC, so there will be no (user) test case for it. :) The current behavior does not match the description on line 35, and I need this function to be able to return null to simply my code. Otherwise, l would have to do something like the following: if (Position == 0) return false; const FormatToken *Previous = AllTokens[Position - 1]; assert(Previous); return Previous->is(tok::comment); Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116318/new/ https://reviews.llvm.org/D116318 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits