ChuanqiXu added a comment. In D116098#3207812 <https://reviews.llvm.org/D116098#3207812>, @urnathan wrote:
> as all exports are also imports, is there a reason we don;t also add the > exports into the import table? I am not sure if it has an intentional reason or it is just an oversight. From my practice, the `Imports` field in C++20 modules is empty all the time. > is Exports really 'ExportedImports' and 'Imports' really > 'NotExportedImports'? If that's the case, this patch is fine. Yes. From the codes, only `export import X` would add `X` to the `exported` list. And if we write `import X`, the `Imports` field is empty too. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116098/new/ https://reviews.llvm.org/D116098 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
