jansvoboda11 added inline comments.
================ Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:275 + const auto &Entry1 = getOrEmplaceSharedEntryForUID(std::move(TEntry)); + const auto &Entry2 = getOrInsertSharedEntryForFilename(Filename, Entry1); + return insertLocalEntryForFilename(Filename, Entry2); ---------------- I'm not sure these should be separate. We could end up in situation where the Filename map contains different entry than the UID map for the same directory entry. I'm tempted to merge these functions into one and perform the updates in a single critical section... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
