curdeius added inline comments.
================ Comment at: clang/unittests/Format/FormatTest.cpp:3819 + Style.IndentExternBlock = FormatStyle::IEBS_NoIndent; + verifyFormat("extern \"C\"\n{ /*13*/\n}", Style); + verifyFormat("extern \"C\"\n{\n" ---------------- owenpan wrote: > curdeius wrote: > > I'd prefer that you split strings after `\n`. I find it easier to read that > > way. > > The same below. > It's everywhere in this function. We should fix them either now or in a > separate patch. Ok, let's do it in another patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115879/new/ https://reviews.llvm.org/D115879 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits