nridge added a comment. In D115425#3190603 <https://reviews.llvm.org/D115425#3190603>, @sammccall wrote:
> I had a discussion with @kadircet about this, we're not sure whether it > factors out enough to be better/simpler overall. (Hand-written ConfigFragment > + ConfigYAML + docs, vs table + generator + stubs of ConfigFragment + > ConfigYAML + docs). > Any thoughts? I feel like clangd's lack of support for non-self-contained files (https://github.com/clangd/clangd/issues/45) is relevant here. With this patch, opening up the .inc files gives you a bunch of errors, and refs in those files do not appear to be found. So, while the patch makes it easier to add new config options, reading / understanding the relevant code becomes harder. Since code is read more often than it's written, that may not be a win. Additionally, there's perhaps a matter of principle where clangd should try to avoid using code patterns (here, non-self-contained files) in its implementation code that it does not support operating on as a tool. These make me lean towards not doing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115425/new/ https://reviews.llvm.org/D115425 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
