mgorny created this revision. mgorny added a reviewer: dexonsmith. mgorny requested review of this revision.
Link BasicTests via explicit target_link_libraries() rather than clang_target_link_libraries() in order to fix linking when building clang against libclang. The latter requires all listed libraries to be part of libclang and omits them if libclang is used. However, LLVMTestingSupport is not part of libclang, so omitting it causes undefined symbols. Link to the library explicitly to follow suit with the 7 other unittest programs. https://reviews.llvm.org/D115580 Files: clang/unittests/Basic/CMakeLists.txt Index: clang/unittests/Basic/CMakeLists.txt =================================================================== --- clang/unittests/Basic/CMakeLists.txt +++ clang/unittests/Basic/CMakeLists.txt @@ -18,5 +18,9 @@ clangAST clangBasic clangLex - LLVMTestingSupport ) + +target_link_libraries(BasicTests + PRIVATE + LLVMTestingSupport +)
Index: clang/unittests/Basic/CMakeLists.txt =================================================================== --- clang/unittests/Basic/CMakeLists.txt +++ clang/unittests/Basic/CMakeLists.txt @@ -18,5 +18,9 @@ clangAST clangBasic clangLex - LLVMTestingSupport ) + +target_link_libraries(BasicTests + PRIVATE + LLVMTestingSupport +)
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
