HsiangKai added a comment.

In D111617#3175167 <https://reviews.llvm.org/D111617#3175167>, @craig.topper 
wrote:

> In D111617#3060377 <https://reviews.llvm.org/D111617#3060377>, @HsiangKai 
> wrote:
>
>> Although it reduces the header size, this patch will increase the binary 
>> size of clang.
>>
>> Debug build:
>> Before this patch:
>>
>>   text            data            bss             dec             hex        
>>      filename
>>   263892591       10838284        500232          275231107       1067b183   
>>      clang-14
>>
>> After this patch:
>>
>>   text            data            bss             dec             hex        
>>      filename
>>   263909721       12085116        500232          276495069       107afadd   
>>      clang-14
>>
>> Release build:
>> Before this patch;
>>
>>   text            data            bss             dec             hex        
>>      filename
>>   382952171       88029764        10264736        481246671       1caf3dcf   
>>      clang-14
>>
>> After this patch:
>>
>>   text            data            bss             dec             hex        
>>      filename
>>   387629483       94652582        10264736        492546801       1d5baaf1   
>>      clang-14
>
> These number indicate the release build is larger than debug. That seems 
> wrong. Am I misreading these numbers?

Indeed, it is strange. The data is got from the first draft version. I have no 
such environment now. I could collect the clang size using the latest 
implementation.
After removing the global static constructor, there is no build time problem 
now.
So, in the latest implementation, we can get the better compile time, smaller 
clang size and acceptable build time.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111617/new/

https://reviews.llvm.org/D111617

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to