pengfei added inline comments.
================ Comment at: clang/test/CodeGen/ms-inline-asm-functions.c:42 __asm mov eax, k; - // CHECK: movl _k, %eax + // CHECK: movl k, %eax __asm mov eax, kptr; ---------------- skan wrote: > This change is strange here. Others looks good to me. Yeah, but we can't roll back all the constraint added D113096 unless we add a separate flag to record it. In fact, using the symbol won't result in any functionality issue. And in this case, I checked the built binary is the same as the one before this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115225/new/ https://reviews.llvm.org/D115225 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits