paulaltin added a comment. > Thanks! Do you need someone to commit on your behalf? If so, what name and > email address would you like used for patch attribution?
That would be great, thanks! You can use "Paul Altin <p...@liquidinstruments.com>" for the attribution. > We're definitely happy to consider these kinds of changes, thank you! We > usually prefer finding ways to silence the diagnostic in code (like casting > to void to silence an unused variable warning, etc) over configuration > options, but that's not always plausible to do and so extra configuration > options are a good fallback solution. Ok, fantastic. I'll go back through the checks that we've disabled and see what I can suggest. Thanks @aaron.ballman! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112881/new/ https://reviews.llvm.org/D112881 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
