Author: Alexey Bataev Date: 2021-12-02T13:33:44-08:00 New Revision: a0839c13fd321bb852870ffab916ad90f691161b
URL: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b DIFF: https://github.com/llvm/llvm-project/commit/a0839c13fd321bb852870ffab916ad90f691161b.diff LOG: [OPENMP]Fix PR51327: Range based for loop not working if range's type is a template. Need to postpone anlysis of the ranged for loops till the actual instantiation to avoid erroneous emission of error messages. Differential Revision: https://reviews.llvm.org/D114560 Added: clang/test/OpenMP/for_loop_auto.cpp Modified: clang/lib/Sema/SemaOpenMP.cpp Removed: ################################################################################ diff --git a/clang/lib/Sema/SemaOpenMP.cpp b/clang/lib/Sema/SemaOpenMP.cpp index b9b000568f3c..4ecd1003ff0b 100644 --- a/clang/lib/Sema/SemaOpenMP.cpp +++ b/clang/lib/Sema/SemaOpenMP.cpp @@ -8804,6 +8804,9 @@ static bool checkOpenMPIterationSpace( } assert(((For && For->getBody()) || (CXXFor && CXXFor->getBody())) && "No loop body."); + // Postpone analysis in dependent contexts for ranged for loops. + if (CXXFor && SemaRef.CurContext->isDependentContext()) + return false; OpenMPIterationSpaceChecker ISC(SemaRef, SupportsNonRectangular, DSA, For ? For->getForLoc() : CXXFor->getForLoc()); diff --git a/clang/test/OpenMP/for_loop_auto.cpp b/clang/test/OpenMP/for_loop_auto.cpp new file mode 100644 index 000000000000..b2c5540a7785 --- /dev/null +++ b/clang/test/OpenMP/for_loop_auto.cpp @@ -0,0 +1,24 @@ +// RUN: %clang_cc1 -verify -fopenmp -ast-print -std=c++20 %s -Wsign-conversion | FileCheck %s +// RUN: %clang_cc1 -fopenmp -x c++ -std=c++20 -emit-pch -o %t %s +// RUN: %clang_cc1 -fopenmp -std=c++20 -include-pch %t -fsyntax-only -verify %s -ast-print | FileCheck %s + +// RUN: %clang_cc1 -verify -fopenmp-simd -ast-print -std=c++20 %s -Wsign-conversion | FileCheck %s +// RUN: %clang_cc1 -fopenmp-simd -x c++ -std=c++20 -emit-pch -o %t %s +// RUN: %clang_cc1 -fopenmp-simd -std=c++20 -include-pch %t -fsyntax-only -verify %s -ast-print | FileCheck %s +// expected-no-diagnostics + +#ifndef HEADER +#define HEADER + +// CHECK: template <> void do_loop(const auto &v) { +// CHECK-NEXT: #pragma omp parallel for +// CHECK-NEXT: for (const auto &i : v) +// CHECK-NEXT: ; +// CHECK-NEXT: } + +void do_loop(const auto &v) { +#pragma omp parallel for + for (const auto &i : v) + ; +} +#endif _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
