jhenderson added a comment. No more comments from me (apart from one minor nit). This should definitely get someone with more familiarity with how these things are configured to take a look though.
================ Comment at: clang/docs/UsersManual.rst:3546 - cmake -G"Visual Studio 15 2017" -T LLVM .. + cmake -G"Visual Studio 17 2022" -T LLVM .. ---------------- I think the missing space should be fixed to :) ================ Comment at: llvm/include/llvm/Support/Compiler.h:106-108 /// Sadly, this is separate from just rvalue reference support because GCC /// and MSVC implemented this later than everything else. This appears to be /// corrected in MSVC 2019 but not MSVC 2017. ---------------- RKSimon wrote: > jhenderson wrote: > > Does this comment need changing? > An even bigger question is - can we get rid of the > LLVM_HAS_RVALUE_REFERENCE_THIS define entirely now? Either as part of this > patch or as a followup Yeah, another patch entirely to sort this would be fine. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
