jwakely added inline comments. Herald added a subscriber: abrachet.
================ Comment at: libcxx/trunk/src/random.cpp:29 +#if defined(_LIBCPP_USING_GETENTROPY) +#include <sys/random.h> +#elif defined(_LIBCPP_USING_DEV_RANDOM) ---------------- musl only declares `getentropy` in `<unistd.h>` not `<sys/random.h>`. Glibc declares it in both. Should `<unistd.h>` also be included when `_LIBCPP_USING_GETENTROPY` is defined, so it can work more portably? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D40319/new/ https://reviews.llvm.org/D40319 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
