mehdi_amini added inline comments.
================
Comment at: mlir/lib/ExecutionEngine/CMakeLists.txt:153
+ set(CMAKE_MODULE_PATH "${HIP_PATH}/lib/cmake/hip" ${CMAKE_MODULE_PATH})
find_package(HIP)
if (NOT HIP_FOUND)
----------------
mehdi_amini wrote:
> Is MLIR really coupled to Clang here? That seems suspicious to me.
In particular, this makes MLIR sensitive to the version actually installed on
the machine, which is independent from whatever clang is in the repo. This
seems undesirable, what am I missing here?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114502/new/
https://reviews.llvm.org/D114502
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
