ChuanqiXu added a comment. In D110215#3139809 <https://reviews.llvm.org/D110215#3139809>, @aaron.ballman wrote:
> In D110215#3139589 <https://reviews.llvm.org/D110215#3139589>, @ChuanqiXu > wrote: > >> Change includes: >> >> - Add parent for newly created global module fragment. >> - Add a test. >> - Rename test directory. Suddenly I found that the names of the tests in CXX >> directory are corresponds to the standard one by one. So my name before is >> not good. >> >> @aaron.ballman @urnathan It looks like @rsmith is busy now. Could you please >> help to review this one? Many Thanks. > > @ChuanqiXu -- I'm happy to take a look (all of your modules patches are still > on my review queue), but I've been in WG14 meetings all week this week and > will be on vacation all week next week. Given the complexity and importance > of the patches, it may be a bit before I can give this a thorough review. (If > you get approval from other trusted reviewers before I get to anything, > please don't let me hold any of the patches up!) Got it. Many thanks! It is great enough to know the review process is going on. I completely understand that we should be very careful about these patches. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110215/new/ https://reviews.llvm.org/D110215 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
