kadircet added a comment.

I agree with Nathan on this one. It's unclear why there are two functions that 
does the same thing in different ways and some usages in sema looks suspicious 
enough to require caution (there are subtle checks for shadowing and whatnot 
and I don't know how these rules come into play in objc contexts).

So I would suggest updating clangd side to look like:

  (isa<DeclContext>(Decl) && cast<DeclContext>(Decl)->isFunctionOrMethod()) || 
Decl->getlKind() == FunctionTemplate


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114058/new/

https://reviews.llvm.org/D114058

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to