djasper accepted this revision.
This revision is now accepted and ready to land.
================
Comment at: lib/Format/SortJavaScriptImports.cpp:248
@@ +247,3 @@
+ // ... then the references in order ...
+ for (JsImportedSymbol *I = Symbols.begin(), *E = Symbols.end(); I != E;) {
+ Buffer += getSourceText(I->Range);
----------------
It's an implementation detail that the iterator of a SmallVector is a
JsImportedSymbol*. Use auto. Also, I find this more readable:
for (auto I = Symbols.begin(), E = Symbols.end(); I != E; ++I) {
if (I != Symbols.begin())
Buffer += ",";
Buffer += getSourceText(I->Range);
}
http://reviews.llvm.org/D20798
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
