skan marked 3 inline comments as done.
skan added inline comments.
================
Comment at: clang/test/CodeGen/ms-inline-asm-static-variable.c:8
+ // CHECK: @arr = internal global [10 x i32]
+ // CHECK: call void asm sideeffect inteldialect "mov dword ptr $0[edx *
$$4],edx", "=*m,{{.*}}([10 x i32]* @arr)
+ __asm mov dword ptr arr[edx*4],edx
----------------
pengfei wrote:
> IIRC, we have limitation on the number. Can you check if it works when we
> have more than 10 global variables.
sorry, which number?
================
Comment at: clang/test/CodeGen/ms-inline-asm-variables.c:35
}
-
----------------
pengfei wrote:
> Unrelated change.
Just delete a blank line, which is done by auto clang-format. I think it's okay.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113096/new/
https://reviews.llvm.org/D113096
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
