smeenai added inline comments.
================
Comment at: clang/lib/Tooling/CMakeLists.txt:29-30
+if (NOT Python3_EXECUTABLE
+    OR WIN32
+    OR APPLE
+    OR GENERATOR_IS_MULTI_CONFIG
----------------
I'm looking at this commit in the context of 
https://bugs.llvm.org/show_bug.cgi?id=52106. Why do we not run the generator 
when targeting Windows or Apple platforms? Note that WIN32 and APPLE reflect 
the target platform, not the platform you're building on.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93164/new/

https://reviews.llvm.org/D93164

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D93164: [AST] Add ge... Shoaib Meenai via Phabricator via cfe-commits

Reply via email to