kstoimenov added inline comments.
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1289
+ }
+ Modified |= ModuleSanitizer.instrumentModule(M);
+ if (Modified)
----------------
At first I had module sanitizer run first, but some tests failed. Is it
possible that the function pass has some side effects, which are used by the
module pass?
================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2829
if (F.getName().startswith("__asan_")) return false;
+ if (F.empty()) return false;
----------------
This was a pain to figure out. Maybe we should apply the same check in HWAsan?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112732/new/
https://reviews.llvm.org/D112732
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
