foad added inline comments.
================ Comment at: llvm/include/llvm/IR/Constants.h:1317 /// would make it harder to remove ConstantExprs altogether. - Instruction *getAsInstruction() const; + Instruction *getAsInstruction(Instruction *InsertBefore = nullptr) const; ---------------- yaxunl wrote: > Can you add a comment about the insertion location when 'InsertBefore' is > nullptr? Thanks. Done, although there are loads of InsertBefore arguments in Instructions.h that all work the same way, and no comments explaining them :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112791/new/ https://reviews.llvm.org/D112791 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
