eopXD marked an inline comment as done.
eopXD added inline comments.
================
Comment at: clang/lib/Basic/Targets/RISCV.cpp:181
}
+ if (MinVLen) {
----------------
khchen wrote:
> please add a note in commit or comment here for those macros are proposed in
> the PR https://github.com/riscv-non-isa/riscv-c-api-doc/pull/21
Added in commit message.
================
Comment at: llvm/include/llvm/Support/RISCVISAInfo.h:65
+ unsigned getMinVLen() const { return MinVLen; }
+ unsigned getMaxEew() const { return MaxEew; }
+ unsigned getMaxEewFp() const { return MaxEewFp; }
----------------
frasercrmck wrote:
> Aside from the discussion about EEW vs. ELEN, something about the
> capitalization irks me. I realise we already have `XLen` but `Eew` looks...
> wrong. If other people disagree then that's fine.
Hi Fraser,
FYI, I think there is a discussion happening
[here](https://github.com/riscv-non-isa/riscv-c-api-doc/pull/21#issuecomment-952307965).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112408/new/
https://reviews.llvm.org/D112408
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
