rmaz added a comment. In D109632#3088479 <https://reviews.llvm.org/D109632#3088479>, @vsapsai wrote:
> Code-wise I'm not aware of any remaining issues. Still need to update the > commit message and to re-run the clang test suite. But you can totally use > the patch for testing. I plan to update D110123 > <https://reviews.llvm.org/D110123> for the review today/tomorrow. Sounds good. > In my limited internal testing I've seen a single extra warning due to > `[(id)specificObject commonMethodName]`. I've discussed it with other > Objective-C developers and the consensus is that with calling methods on `id` > you cannot predict which exactly method signature will be selected and the > recommended solution to cast `specificObject` to correct type with the known > method signature. It might be worth running a more extensive test and make > sure there are no unintended consequences. That will take me around a week or > slightly more. I don't recall any issues on my last benchmark, but i'll run the patch across all of our modular files and see if anything comes up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109632/new/ https://reviews.llvm.org/D109632 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
