aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D112334#3081213 <https://reviews.llvm.org/D112334#3081213>, @carlosgalvezp wrote: > Btw, regarding this `CHECK-MESSAGES-NOT`, how does it work? I can't find it > in `check_clang_tidy.py`. Wouldn't the test fail anyway if unexpected > warnings are printed? FileCheck matches input CHECK lines with output lines, so if there's no CHECK line for a particular output, FileCheck won't report any problems with it. (`-verify` is used by the frontend to verify diagnostics, but that's not something that can be used within clang-tidy currently.) That said, I'm not entirely certain of the mechanisms behind `CHECK-MESSAGES-NOT` in the python scripts. LGTM aside from a nit. ================ Comment at: clang-tools-extra/clang-tidy/readability/StaticAccessedThroughInstanceCheck.cpp:75 + // Do not warn for CUDA built-in variables. + if (StringRef(BaseTypeName).contains("__cuda_builtin_")) + return; ---------------- I presume we want this to strictly be a prefix? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112334/new/ https://reviews.llvm.org/D112334 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
