sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: clang-tools-extra/clangd/TUScheduler.cpp:904 const ParseInputs &Inputs = Req.Inputs; + bool RebuiltPreamble = true; ---------------- I think it would be clearer to invert the sense here (`ReusedPreamble=false`). This avoids the "tension" of saying `RebuiltPreamble=true` when we haven't built one yet, and then having to ensure we satisfy that promise later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112137/new/ https://reviews.llvm.org/D112137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
