csmulhern added a comment.

In D109557#3063563 <https://reviews.llvm.org/D109557#3063563>, @MyDeveloperDay 
wrote:

>> The you quoted would, in my mind, be formatted like this:
>>
>>   void foo() {
>>       if (
>>           quitelongarg != (alsolongarg - 1)
>>       ) { // ABC is a very longgggggggggggg comment
>>           return;
>>       }
>>   }
>>
>> This is because I don't allow breaking the closing paren without breaking 
>> after the opening paren, but this might be only my own style.
>
> Yes, this is not what you are going to get with this revision, we need to 
> decide if that is what is expected

Sorry for the delay in responding. I have not had the free time recently to 
address this feedback, but hope to get to it soon. I appreciate this formatting 
case being called out, and agree with the formatting proposed here. I will 
update the revision accordingly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109557/new/

https://reviews.llvm.org/D109557

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to