nickdesaulniers added a comment.

In D107613#3040402 <https://reviews.llvm.org/D107613#3040402>, @dschuff wrote:

> It looks like this error is intended to catch mismatches for attributes that 
> can affect codegen such as noreturn (in which case it makes sense to have it 
> as an error) but it also now fires for cases such as 
> `__attribute__(warning())` which often do not duplicate the attribute on the 
> definition. Is that intended?

Duplicating the attribute on the definition is not needed for 
`__attribute__(warning())`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107613/new/

https://reviews.llvm.org/D107613

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D107613: [Clang][... Derek Schuff via Phabricator via cfe-commits
    • [PATCH] D107613: [Cl... Nick Desaulniers via Phabricator via cfe-commits

Reply via email to