This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd3caa99bd87: [clang-format] [docs] [NFC] improve clarity in the QualifierAlignment warning (authored by MyDeveloperDay).
Changed prior to commit: https://reviews.llvm.org/D110801?vs=376140&id=376700#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110801/new/ https://reviews.llvm.org/D110801 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.h Index: clang/include/clang/Format/Format.h =================================================================== --- clang/include/clang/Format/Format.h +++ clang/include/clang/Format/Format.h @@ -1898,7 +1898,11 @@ /// Different ways to arrange specifiers and qualifiers (e.g. const/volatile). /// \warning - /// ``QualifierAlignment`` COULD lead to incorrect code generation. + /// Setting ``QualifierAlignment`` to something other than `Leave`, COULD + /// lead to incorrect code formatting due to incorrect decisions made due to + /// clang-formats lack of complete semantic information. + /// As such extra care should be taken to review code changes made by the use + /// of this option. /// \endwarning /// \version 14 QualifierAlignmentStyle QualifierAlignment; Index: clang/docs/ClangFormatStyleOptions.rst =================================================================== --- clang/docs/ClangFormatStyleOptions.rst +++ clang/docs/ClangFormatStyleOptions.rst @@ -3238,7 +3238,11 @@ .. warning:: - ``QualifierAlignment`` COULD lead to incorrect code generation. + Setting ``QualifierAlignment`` to something other than `Leave`, COULD + lead to incorrect code formatting due to incorrect decisions made due to + clang-formats lack of complete semantic information. + As such extra care should be taken to review code changes made by the use + of this option. Possible values:
Index: clang/include/clang/Format/Format.h =================================================================== --- clang/include/clang/Format/Format.h +++ clang/include/clang/Format/Format.h @@ -1898,7 +1898,11 @@ /// Different ways to arrange specifiers and qualifiers (e.g. const/volatile). /// \warning - /// ``QualifierAlignment`` COULD lead to incorrect code generation. + /// Setting ``QualifierAlignment`` to something other than `Leave`, COULD + /// lead to incorrect code formatting due to incorrect decisions made due to + /// clang-formats lack of complete semantic information. + /// As such extra care should be taken to review code changes made by the use + /// of this option. /// \endwarning /// \version 14 QualifierAlignmentStyle QualifierAlignment; Index: clang/docs/ClangFormatStyleOptions.rst =================================================================== --- clang/docs/ClangFormatStyleOptions.rst +++ clang/docs/ClangFormatStyleOptions.rst @@ -3238,7 +3238,11 @@ .. warning:: - ``QualifierAlignment`` COULD lead to incorrect code generation. + Setting ``QualifierAlignment`` to something other than `Leave`, COULD + lead to incorrect code formatting due to incorrect decisions made due to + clang-formats lack of complete semantic information. + As such extra care should be taken to review code changes made by the use + of this option. Possible values:
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
