HazardyKnusperkeks accepted this revision.
HazardyKnusperkeks added a comment.
This revision is now accepted and ready to land.

Let's give it a first shot. When it has landed maybe I find the time to look 
into the attributes. ;)



================
Comment at: clang/lib/Format/QualifierAlignmentFixer.cpp:449
+    return false;
+  if (Tok->is(TT_TypenameMacro))
+    return false;
----------------
MyDeveloperDay wrote:
> HazardyKnusperkeks wrote:
> > I think this is still right, because it is a type (according to the 
> > configuration).
> yeah, let's do this a different way after we have landed this, I was thinking 
> about having a list of "Types" that users could specify that would help us 
> classify tok::identifiers a little better (could help with some of the 
> casting issues we've seen before)
> 
> I notice in projects like Linux they make heavy use of these ForeachMacros 
> and StatementMacros, I don't want to steal another list I'd rather we had one 
> that was very specific to types, I think this could help
We can do that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to