kbobyrev added a comment.

Hey, thanks for noticing!

Ugh, I think that's not good, I was trying to make sure the `io.open` piece 
really works with Python 2 and Python 3 as this was the purpose fo the patch :( 
I need t check that again, I think it's really unfortunate to lose Python 2 
support if that's the only reason here. Personally, I think moving to Python 3 
completely is a great idea but I would anticipate many buildbots and some older 
distro versions not having it/being reluctant. As of right now, we still have 
the >= 2.7 requirement so I think the best option is to keep both somehow :(

Thanks for bringing it up!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109127/new/

https://reviews.llvm.org/D109127

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D109127: Use python... Matt Beardsley via Phabricator via cfe-commits
    • [PATCH] D109127: Use p... Kirill Bobyrev via Phabricator via cfe-commits

Reply via email to