jrtc27 added a comment. In D108886#2977873 <https://reviews.llvm.org/D108886#2977873>, @apivovarov wrote:
> In D108886#2977733 <https://reviews.llvm.org/D108886#2977733>, @jrtc27 wrote: > >> You don't need to tag people as well as adding them as reviewers, it's just >> annoying. Also, it's only been four days; the developer policy is that for >> non-urgent patches you shouldn't ping more than once a week. > > Jessica, Contributing to LLVM says - To make sure the right people see your > patch, please select suitable reviewers and add them to your patch when > requesting a review. Suitable reviewers are the code owner (see > CODE_OWNERS.txt) and other people doing work in the area your patch touches. > > The people I added as reviewers have contributed to RISC-V target code in the > past. Yeah, but that means adding them as reviewers, you don't also need to @ them in general. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108886/new/ https://reviews.llvm.org/D108886 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
