[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

[Jim Lin via Phabricator via cfe-commits]

Jim added inline comments.


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:387
+                            ExtensionInfoIterator->Version.Minor);
+      if (ExtName == "e")
+        HasE = true;
----------------
Does this need to check it is invalid if XLen is 64?


================
Comment at: llvm/lib/Support/RISCVISAInfo.cpp:394
+  if (!HasE)
+    ISAInfo->addExtension("i", 2, 0);
+
----------------
Why not get the version of i from SupportedExtensions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits