rsmith added a comment.

Note that there's a potential ABI impact here: because we accidentally put the 
`__cxx_global_init` function into a COMDAT with the variable, that meant that 
the `_ZTH` symbol (which is an alias to `__cxx_global_init`) also pointed into 
that same COMDAT. I'm not sure how much that matters given that the old 
behavior was broken.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108680/new/

https://reviews.llvm.org/D108680

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D108680: ... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D108... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D108... John McCall via Phabricator via cfe-commits
    • [PATCH] D108... Richard Smith - zygoloid via Phabricator via cfe-commits

Reply via email to