rjmccall accepted this revision. rjmccall added a comment. This revision is now accepted and ready to land.
Okay, thanks, seems like a good approach. ================ Comment at: clang/test/CodeGenObjC/convert-messages-to-runtime-calls.m:34 + // CALLS-NOT: {{call.*@llvm.objc.release}} + // CALLS-NOT: {{tail call.*@llvm.objc.autorelease}} // CALLS: {{call.*@objc_alloc}} ---------------- This only actually tests for the absence of these lines between the CHECK-LABEL and the first CALLS line below, so I don't think it does much. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105671/new/ https://reviews.llvm.org/D105671 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits