craig.topper added a comment.
I'm not opposed either.
================
Comment at: llvm/include/llvm/Support/X86TargetParser.def:220
+
+// FIXME: When commented out features are supported in LLVM, enable them here.
+CPU_SPECIFIC("generic", 'A', "")
----------------
erichkeane wrote:
> RKSimon wrote:
> > what commented out features?
> So this is copy/pasted from:
> https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/X86Target.def#L70
> (where it will probably be removed in a future patch?).
>
> That comment came from here: https://reviews.llvm.org/D47474
>
> If you look at the 'diff' here:
> https://reviews.llvm.org/D47474?vs=148894&id=156484#toc (1st patch vs last)
> You can see that the original used a bitmask to create the values rather than
> the string list (as suggested by @craig.topper in the review). That version
> had some commented out in the bitmasks.
>
> However, I never removed the comment! So this comment likely should just be
> deleted.
I'm not sure the commented out features made it over. For example, FEATURE_TSX
was one of the commented out values, but +tsx doesn't appear in these strings.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108422/new/
https://reviews.llvm.org/D108422
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
