JDevlieghere added inline comments.
================
Comment at: llvm/include/llvm/CodeGen/MIRSampleProfile.h:59
+ MIRSampleLoader(
+ std::make_unique<MIRProfileLoader>(FileName, RemappingFileName)) {
+ LowBit = getFSPassBitBegin(P);
----------------
You're instantiating a forward-declared type. This breaks the modules build:
https://green.lab.llvm.org/green/job/lldb-cmake/34450/console
================
Comment at: llvm/lib/CodeGen/MIRSampleProfile.cpp:289
+
+bool MIRProfileLoaderPass::runOnMachineFunction(MachineFunction &MF) {
+ if (!MIRSampleLoader->isValid())
----------------
Why is this outside the `llvm` namespace?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107878/new/
https://reviews.llvm.org/D107878
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
