melver accepted this revision. melver added a comment. LGTM with the LangRef change.
Thanks! ================ Comment at: llvm/lib/AsmParser/LLLexer.cpp:646 KEYWORD(dereferenceable_or_null); + KEYWORD(disable_sanitizer_instrumentation); KEYWORD(elementtype); ---------------- glider wrote: > melver wrote: > > Do the tests pass? > > > > There should also be the code that actually turns the token into the > > attribute in llvm/lib/AsmParser/LLParser.cpp > check-llvm and check-clang pass for me, check-all seems to choke on some > unrelated bugs. > > LLParser is using Tablegen now, no need to change it: > https://github.com/llvm/llvm-project/blob/main/llvm/lib/AsmParser/LLParser.cpp#L1247 Ah, nice, I missed that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108029/new/ https://reviews.llvm.org/D108029 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
