bcain added inline comments.
================
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124
+
+bool internal_iserror(uptr retval, int *rverrno) {
+ if (retval == (uptr)-1) {
----------------
vitalybuka wrote:
> sidneym wrote:
> > bcain wrote:
> > > @sidneym Can you confirm that this implementation looks correct? I
> > > thought the convention was -1 for failed syscalls.
> > Maybe it should be <0 instead.
> Why it's not -4095 like in other versions?
> Why it's not -4095 like in other versions?
It should be, I misunderstood the intent.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108083/new/
https://reviews.llvm.org/D108083
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
