melver accepted this revision. melver added inline comments.
================ Comment at: clang/docs/MemorySanitizer.rst:91 + +The ``disable_sanitizer_instrumentation`` attribute can be applied to a certain +function to prevent all kinds of instrumentation. This attribute overrides ---------------- Could apply a similar wording to what I suggested on https://reviews.llvm.org/D108202 to deter people from using it. ================ Comment at: clang/test/CodeGen/sanitize-memory-disable.c:11 +// +// CHECK: @instrumented1 +// KMSAN: __msan_get_context_state ---------------- Similar to https://reviews.llvm.org/D108202, could use `CHECK-LABEL`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108199/new/ https://reviews.llvm.org/D108199 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits