gandhi21299 marked 5 inline comments as done. gandhi21299 added inline comments.
================ Comment at: clang/test/CodeGenOpenCL/atomics-remarks-gfx90a.cl:9 +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple=amdgcn-amd-amdhsa -target-cpu gfx90a \ +// RUN: -Rpass=si-lower -munsafe-fp-atomics %s -S -o - 2>&1 | \ ---------------- rampitec wrote: > You are compiling 2 functions with 2 different sets of options. Essentially > it is unclear what are you checking because either half skips half of the > remarks. Either compile a single function differently or make 2 different > tests. I will create 2 seperate tests ================ Comment at: llvm/test/CodeGen/AMDGPU/atomics-remarks-gfx90a.ll:108 + +; GFX90A-HW: Hardware instruction generated for atomic fadd operation at memory scope system due to an unsafe request. +; GFX90A-HW: Hardware instruction generated for atomic fadd operation at memory scope agent due to an unsafe request. ---------------- rampitec wrote: > Does it print a function name before the diagnostics? Label checks would be > useful. Nope, it does not. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108150/new/ https://reviews.llvm.org/D108150 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
