sammccall added a comment.

(First just the bug that I suspect is blocking you from testing this, design 
feedback to come)



================
Comment at: clang-tools-extra/clangd/ClangdServer.cpp:184
+    }
+    AddIndex(SLIndex->get());
+  }
----------------
this pointer will dangle after the `if` block finishes (the local `auto` owns 
the index)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108119/new/

https://reviews.llvm.org/D108119

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to