dblaikie added a comment.
Patch description probably needs an update - looks like it's out of date ("Add
-Wimplicit-fallthrough-unreachable, which is default enabled with
-Wimplicit-fallthrough" should read, I guess "Add
-Wunreachable-code-fallthrough, which is default enabled with
-Wunreachable-code" - also, I might avoid using the "default enabled" as it may
lead to some confusion/sound like it's suggesting that "this subwarning is on
by default as it's grouped under this other on-by-default warning", which isn't
the case - maybe "which is enabled with -Wunreachable-code" would suffice? or
"which is part of the -Wunreachable-code group")
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107933/new/
https://reviews.llvm.org/D107933
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
