Quuxplusone added a comment. > I suggest that this patch be divided into two patches. In the current patch, > fix the wrong AutoFix. What the current check should look like is left in the > second patch for discussion. @Sockke do you mind simplifying this patch and > only achieving the first goal?
FWIW, I agree. The original "case 1" was fixing wrong behavior; the original "case 2" was adding a new feature. Let's see just the "case 1" bugfix (and regression test), and then once that's being properly handled and regression-tested, it'll be safer to mess around with new feature work. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107450/new/ https://reviews.llvm.org/D107450 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
