MaskRay accepted this revision.
MaskRay added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/test/Driver/hexagon-toolchain-linux.c:106
+// CHECK008: InstalledDir: [[INSTALLED_DIR:.+]]
+// CHECK008: "-resource-dir" "[[RESOURCE:[^"]+]]"
+// CHECK008-SAME: {{^}} "-internal-isystem" "[[RESOURCE]]/include"
----------------
If you don't specify `-resource-dir=%S/Inputs/resource_dir`, under certain
CMake configurations, the `-resource-dir` may be unreliable.
================
Comment at: clang/test/Driver/hexagon-toolchain-linux.c:117
+// CHECK009-SAME: {{^}} "-internal-isystem" "[[RESOURCE]]/include"
+// CHECK009-SAME: {{^}} "-internal-externc-isystem"
"[[INSTALLED_DIR]]/../target/hexagon/include"
----------------
Some `/` may need to be `\`.
The Windows premerge test may give you a failure.
(That's why I just add `UNSUPPORTED: system-windows` to not deal with the
backslash madness.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106737/new/
https://reviews.llvm.org/D106737
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
