cebowleratibm added a comment. In D107242#2932289 <https://reviews.llvm.org/D107242#2932289>, @joerg wrote:
> I'm puzzled by this change. I don't think we have any case so far where the > compiler behavior changes with the host OS and I don't think it should. > What's the point / use case of this macro? __HOS_AIX__ is a macro defined by the XL C/C++ compilers on AIX. Although there was never an AIX cross compiler offering from IBM, the intention of the macro was to indicate that the host is AIX. __HOS_AIX__ is being defined to minimize porting pain for existing code compiled with xlc/xlC. Given that LLVM has the infrastructure to be a cross-compiler, I consider it important to implement the macro to the original intention. Because the macro is a "legacy" AIX xlc macro I don't think it's relevant to define for non-AIX targets. If there's no objection to the change I can work with Jake to elaborate on the comments with an improved commit message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107242/new/ https://reviews.llvm.org/D107242 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
