nickdesaulniers added inline comments.
================ Comment at: clang/lib/Sema/SemaDecl.cpp:3685 + << NRA; + notePreviousDefinition(Old, New->getLocation()); + } ---------------- ah, this isn't quite right. It replaces warning of the first declaration with warning of the first definition. This should instead use `Diag(Old->getLocation(), diag::note_previous_declaration);` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107613/new/ https://reviews.llvm.org/D107613 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
