ro added inline comments.
================ Comment at: clang/tools/libclang/libclang.map:1 -/* If you add a symbol to this file, make sure to add it with the correct - * version. For example, if the LLVM main branch is LLVM 14.0.0, add new - * symbols with the version LLVM_14. - * On platforms where versions scripts are not used, this file will be used to - * generate a list of exports for libclang.so - */ - +# If you add a symbol to this file, make sure to add it with the correct +# version. For example, if the LLVM main branch is LLVM 14.0.0, add new ---------------- MaskRay wrote: > MaskRay wrote: > > ro wrote: > > > MaskRay wrote: > > > > GNU ld doesn't support `#` comments. ld.lld supports it. > > > Drats, I'd have sworn they supported `#' comments, too, > > > especially since the version script syntax originated with > > > Sun and was later adopted by GNU `ld`. > > Confirmed that GNU ld and gold support `#` in version scripts, but not in > > linker scripts. > > > > ld.lld supports both. > > > > Using `#` is fine to me if Solaris ld doesn't support `/*` in GNU version > > scripts. > Correction: only GNU ld doesn't support `#` in linker scripts. > > ld.lld and gold support `#` everywhere. > > Filed a GNU ld feature request > https://sourceware.org/bugzilla/show_bug.cgi?id=28198 I'd only checked `ld.texi` and didn't even think of trying it when it wasn't documented there. I can ask about C-style comments being added to Solaris `ld`, but I've never encountered the need before. So the original patch is ok after all? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107559/new/ https://reviews.llvm.org/D107559 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
