cebowleratibm accepted this revision.
cebowleratibm added a comment.
This revision is now accepted and ready to land.

It would be nice if the diagnostic could be deferred to layout, in case the 
struct is defined but not used in a header, but I understand that #pragma 
pack(1) and #pragma align(packed) become ambiguous at the point of layout.  I 
think this is a reasonable diagnostic given the impact of silently incompatible 
codegen.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107506/new/

https://reviews.llvm.org/D107506

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to