sfertile added a comment. Thanks Steven, LGTM.
================ Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:11 + +// CHECK: @c = global %struct.C zeroinitializer, align 2 ---------------- stevewan wrote: > sfertile wrote: > > Minor nit: I think the other test can live in this file, highlighting the > > difference between the 2 cases is nice. Also I think we should add a > > typedef test in here as well. > Merged the tests as suggested. We have the typedef coverage in > `aix-power-alignment-typedef.cpp` and `aix-power-alignment-typedef2.cpp`, not > sure if want to merge those as well. No need to merge those as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
