dougpuob marked 3 inline comments as done. dougpuob added inline comments.
================ Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy:1 +Checks: readability-identifier-naming +CheckOptions: ---------------- whisperity wrote: > I do not think this file should have the //execute// bit set... I will change it to 664. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy:3 +CheckOptions: + - { key: readability-identifier-naming.AbstractClassCase , value: CamelCase } + - { key: readability-identifier-naming.ClassCase , value: CamelCase } ---------------- whisperity wrote: > thakis wrote: > > can we drop all the spaces here? :) > And maybe even the object brackets. Sure. ================ Comment at: clang-tools-extra/test/clang-tidy/checkers/Inputs/readability-identifier-naming/hungarian-notation1/.clang-tidy:3 +CheckOptions: + - { key: readability-identifier-naming.AbstractClassCase , value: CamelCase } + - { key: readability-identifier-naming.ClassCase , value: CamelCase } ---------------- dougpuob wrote: > whisperity wrote: > > thakis wrote: > > > can we drop all the spaces here? :) > > And maybe even the object brackets. > Sure. OK Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107325/new/ https://reviews.llvm.org/D107325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits